empire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francis De Brabandere (JIRA)" <empire-db-...@incubator.apache.org>
Subject [jira] [Commented] (EMPIREDB-187) DateUtilsTest fails on specific dates + code it is testing is not used
Date Mon, 29 Jul 2013 10:01:49 GMT

    [ https://issues.apache.org/jira/browse/EMPIREDB-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722306#comment-13722306
] 

Francis De Brabandere commented on EMPIREDB-187:
------------------------------------------------

fixed in revision 1507990
There is a chance that somebody is using that method but still I think it's better if we remove
it.
                
> DateUtilsTest fails on specific dates + code it is testing is not used
> ----------------------------------------------------------------------
>
>                 Key: EMPIREDB-187
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-187
>             Project: Empire-DB
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: empire-db-2.4.1
>            Reporter: Francis De Brabandere
>            Assignee: Francis De Brabandere
>            Priority: Trivial
>             Fix For: empire-db-2.4.2
>
>
> Date and time code is non-trivial. The current test DateUtilsTest#testGetDateTimeFromNow
seems to fail sometimes.
> I discovered that the functionallity tested is nowhere used so I suggest to remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message