empire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francis De Brabandere (JIRA)" <empire-db-...@incubator.apache.org>
Subject [jira] [Commented] (EMPIREDB-170) DBDatabase.querySingleValue(cmd, conn) does not care about DataType
Date Sat, 22 Sep 2012 18:39:07 GMT

    [ https://issues.apache.org/jira/browse/EMPIREDB-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461239#comment-13461239

Francis De Brabandere commented on EMPIREDB-170:

Response from rainer:

Personally I would prefer not to have this dodgy logic with cmd.getSelectExprList() in that
I would rather simply create new overload that has the desired signature

public final Object querySingleValue(DBCommand cmd, DataType dataType, Connection conn)
    return querySingleValue(cmd.getSelect(), cmd.getParamValues(), dataType, conn);

Everything else is up to the caller.

We should keep it small and simple.
> DBDatabase.querySingleValue(cmd, conn) does not care about DataType
> -------------------------------------------------------------------
>                 Key: EMPIREDB-170
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-170
>             Project: Empire-DB
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: empire-db-2.4.2
>         Environment: any
>            Reporter: Daniel Weidele
>            Priority: Minor
>         Attachments: patch.txt
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> Making use of DBDatabase.querySingleValue(cmd, conn) seems to ignore the DataType of
the select expression. This can result in erreneous behaviour, e.g. when trying to select
a number(1,0) column as boolean for Oracle, as empire-db reads the value as Number, instead
of the declared BOOL in table defintions.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message