empire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Weidele (JIRA)" <empire-db-...@incubator.apache.org>
Subject [jira] [Commented] (EMPIREDB-170) DBDatabase.querySingleValue(cmd, conn) does not care about DataType
Date Mon, 17 Sep 2012 06:53:07 GMT

    [ https://issues.apache.org/jira/browse/EMPIREDB-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456840#comment-13456840

Daniel Weidele commented on EMPIREDB-170:

I added the following method to DBDatabase (in core project).

     * Returns the value of the first row/column of a sql-query as an object.
     * If the query does not return a result a QueryNoResultException is thrown
     * @param cmd
     *            the Command object that contains the select statement
     * @param conn
     *            a valid connection to the database.
     * @return the value of the first column in the first row of the query
    public final Object querySingleValue(DBCommand cmd, Connection conn)
        if (cmd.getSelectExprList() != null && cmd.getSelectExprList().length >
0 && cmd.getSelectExprList()[0] != null)
            return querySingleValue(cmd.getSelect(), cmd.getParamValues(), cmd.getSelectExprList()[0].getDataType(),
        return querySingleValue(cmd.getSelect(), cmd.getParamValues(), conn);
> DBDatabase.querySingleValue(cmd, conn) does not care about DataType
> -------------------------------------------------------------------
>                 Key: EMPIREDB-170
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-170
>             Project: Empire-DB
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: empire-db-2.4.2
>         Environment: any
>            Reporter: Daniel Weidele
>            Priority: Minor
>         Attachments: patch.txt
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> Making use of DBDatabase.querySingleValue(cmd, conn) seems to ignore the DataType of
the select expression. This can result in erreneous behaviour, e.g. when trying to select
a number(1,0) column as boolean for Oracle, as empire-db reads the value as Number, instead
of the declared BOOL in table defintions.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message