empire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francis De Brabandere (JIRA)" <empire-db-...@incubator.apache.org>
Subject [jira] Commented: (EMPIREDB-85) Remove declarations of unused dependencies (from pom.xml)
Date Mon, 01 Nov 2010 23:00:25 GMT

    [ https://issues.apache.org/jira/browse/EMPIREDB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927211#action_12927211

Francis De Brabandere commented on EMPIREDB-85:

Hi Marcio,

Thanks for reporting this!

For now I ignored the examples.
Removed commons-collections dependency, as well as some others (see commit)
Mockito and hsqldb are test-scope dependencies which are valid, better to just look at compile-time
with this command:
mvn dependency:analyze -DignoreNonCompile

> Remove declarations of unused dependencies (from pom.xml) 
> ----------------------------------------------------------
>                 Key: EMPIREDB-85
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-85
>             Project: Empire-DB
>          Issue Type: Bug
>          Components: CodeGenerator, Core, Struts2 Extentions
>    Affects Versions: empire-db-2.0.6-incubating
>            Reporter: Marcio Mazza
>            Assignee: Francis De Brabandere
>            Priority: Trivial
>             Fix For: empire-db-2.0.7-incubating 
>         Attachments: empire-db_summary-of-dependency-analyse.txt
> By running "mvn dependency:analyze"
> one can detect that there are some declared dependencies (in the pom files) which are
not used indeed by the codebase.
> Shouldn't they be removed?
> Running against
>   http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
> e.g., for the CORE we see that commons-collections, mockito and hsqldb were declared
but not used at all.
> I see that the mockito dependency comes from the parent, so maybe that should be left
> The output of "mvn dependency:analyze" for the core is, in summary:
> ------------------------------------------------------------------------
>  Apache Empire-db Core
> ------------------------------------------------------------------------
> [WARNING] Unused declared dependencies found:
> [WARNING]    commons-collections:commons-collections:jar:3.2.1:compile
> [WARNING]    org.mockito:mockito-core:jar:1.8.2:test
> [WARNING]    hsqldb:hsqldb:jar:

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message