empire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From doeb...@apache.org
Subject svn commit: r907832 - in /incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr: column/DBAliasExpr.java compare/DBCompareColExpr.java
Date Mon, 08 Feb 2010 22:39:01 GMT
Author: doebele
Date: Mon Feb  8 22:39:00 2010
New Revision: 907832

URL: http://svn.apache.org/viewvc?rev=907832&view=rev
Log:
Allow mixed case in Alias expression

Modified:
    incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/column/DBAliasExpr.java
    incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/compare/DBCompareColExpr.java

Modified: incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/column/DBAliasExpr.java
URL: http://svn.apache.org/viewvc/incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/column/DBAliasExpr.java?rev=907832&r1=907831&r2=907832&view=diff
==============================================================================
--- incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/column/DBAliasExpr.java
(original)
+++ incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/column/DBAliasExpr.java
Mon Feb  8 22:39:00 2010
@@ -56,7 +56,7 @@
         else
             this.expr = expr;
         // Set alias name
-        this.alias = alias.toUpperCase();
+        this.alias = alias; // .toUpperCase() Why?;
     }
 
     /**

Modified: incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/compare/DBCompareColExpr.java
URL: http://svn.apache.org/viewvc/incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/compare/DBCompareColExpr.java?rev=907832&r1=907831&r2=907832&view=diff
==============================================================================
--- incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/compare/DBCompareColExpr.java
(original)
+++ incubator/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/expr/compare/DBCompareColExpr.java
Mon Feb  8 22:39:00 2010
@@ -126,7 +126,7 @@
      * @param context the comparative context e.g. (CMP_EQUAL, CMP_SMALLER)
      */
     public void addCompareExpr(StringBuilder buf, long context)
-    { // Zusammenbauen
+    {   // Assemble expression
         String arraySep = "+";
         DBCmpType op = cmpop;
         switch (op)
@@ -149,7 +149,7 @@
         { // Null oder Not Null!
             op = DBCmpType.getNullType(op);
         }
-        // Zusammenbauen
+        // Add comparison operator and value
         switch (op)
         {
             case EQUAL:
@@ -202,8 +202,6 @@
                 buf.append(")");
                 valsql = null;
                 break;
-            // Wer hat das gemacht?
-            //   case LIKE_UPPER: buf.append(" LIKE upper(");buf.append(valsql);buf.append(")");valsql=null;break;
             default:
                 // NONE
                 buf.append(" ");



Mime
View raw message