empire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franci...@apache.org
Subject svn commit: r826516 - in /incubator/empire-db/trunk/empire-db-examples: empire-db-example-cxf/src/main/java/org/apache/empire/samples/cxf/wssample/server/ empire-db-example-struts2/src/main/java/org/apache/empire/struts2/websample/web/
Date Sun, 18 Oct 2009 20:28:39 GMT
Author: francisdb
Date: Sun Oct 18 20:28:39 2009
New Revision: 826516

URL: http://svn.apache.org/viewvc?rev=826516&view=rev
Log:
FindBugs: Missing throw for exception

Modified:
    incubator/empire-db/trunk/empire-db-examples/empire-db-example-cxf/src/main/java/org/apache/empire/samples/cxf/wssample/server/ServerControl.java
    incubator/empire-db/trunk/empire-db-examples/empire-db-example-struts2/src/main/java/org/apache/empire/struts2/websample/web/SampleApplication.java

Modified: incubator/empire-db/trunk/empire-db-examples/empire-db-example-cxf/src/main/java/org/apache/empire/samples/cxf/wssample/server/ServerControl.java
URL: http://svn.apache.org/viewvc/incubator/empire-db/trunk/empire-db-examples/empire-db-example-cxf/src/main/java/org/apache/empire/samples/cxf/wssample/server/ServerControl.java?rev=826516&r1=826515&r2=826516&view=diff
==============================================================================
--- incubator/empire-db/trunk/empire-db-examples/empire-db-example-cxf/src/main/java/org/apache/empire/samples/cxf/wssample/server/ServerControl.java
(original)
+++ incubator/empire-db/trunk/empire-db-examples/empire-db-example-cxf/src/main/java/org/apache/empire/samples/cxf/wssample/server/ServerControl.java
Sun Oct 18 20:28:39 2009
@@ -231,8 +231,9 @@
         script.run(driver, conn, false);
         db.commit(conn);
         // Open again
-        if (!db.isOpen() && !db.open(driver, conn))
-            new RuntimeException(driver.getErrorMessage());
+        if (!db.isOpen() && !db.open(driver, conn)){
+            throw new RuntimeException(driver.getErrorMessage());
+        }
         // Insert Sample Departments
         int idDevDep = insertDepartmentSampleRecord(conn, "Development", "ITTK");
         int idSalDep = insertDepartmentSampleRecord(conn, "Sales", "ITTK");

Modified: incubator/empire-db/trunk/empire-db-examples/empire-db-example-struts2/src/main/java/org/apache/empire/struts2/websample/web/SampleApplication.java
URL: http://svn.apache.org/viewvc/incubator/empire-db/trunk/empire-db-examples/empire-db-example-struts2/src/main/java/org/apache/empire/struts2/websample/web/SampleApplication.java?rev=826516&r1=826515&r2=826516&view=diff
==============================================================================
--- incubator/empire-db/trunk/empire-db-examples/empire-db-example-struts2/src/main/java/org/apache/empire/struts2/websample/web/SampleApplication.java
(original)
+++ incubator/empire-db/trunk/empire-db-examples/empire-db-example-struts2/src/main/java/org/apache/empire/struts2/websample/web/SampleApplication.java
Sun Oct 18 20:28:39 2009
@@ -216,8 +216,9 @@
         script.run(driver, conn, false);
         db.commit(conn);
         // Open again
-        if (!db.isOpen() && !db.open(driver, conn))
-            new RuntimeException(driver.getErrorMessage());
+        if (!db.isOpen() && !db.open(driver, conn)){
+            throw new RuntimeException(driver.getErrorMessage());
+        }
 		// Insert Sample Departments
 		int idDevDep = insertDepartmentSampleRecord(conn, "Development", "ITTK");
 		int idSalDep = insertDepartmentSampleRecord(conn, "Sales", "ITTK");



Mime
View raw message