edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christofer Dutz <christofer.d...@c-ware.de>
Subject Re: maven: d3.legend.js mods
Date Wed, 04 Oct 2017 09:45:27 GMT
Hi Dale,

Having another look at the code and the running example, it seems as if this conditionally
sets the width of something depending on the title. I did have a look at the running application
and for me the application seems to work nicely.

Chris



Am 03.10.17, 23:45 schrieb "Dale LaBossiere" <dml.apache@gmail.com>:

    Chris, 
    
    I see the downloaded d3.legend.js is much smaller than what was in our repo.
    I see the repo version has some custom Edgent lines of code in it.  e.g.
    
            return k.startsWith("COUNTEROP”)
                 || k.startsWith("STREAMSCOPE”);
        if (isTupleFlowLegend)
        if (legendTitle && legendTitle === "Stream tags") {
       } else if (legendTitle && legendTitle === "Oplet kind" || legendTitle === "Tuple
count"){
            .attr("width", legendTitle === "Oplet kind" ? 8 : 10)
    
    Did you do something elsewhere to account for that?
    
    
    > On Oct 3, 2017, at 3:23 PM, Dale LaBossiere <dml.apache@gmail.com> wrote:
    > 
    > Hi Chris, I picked up the d3.legend.js refactoring (7d8a69f <https://github.com/apache/incubator-edgent/commit/7d8a69f>)
and it causes this error in Eclipse:
    > 
    > Plugin execution not covered by lifecycle configuration: com.googlecode.maven-download-plugin:download-maven-plugin:1.2.1:wget
(execution: get-d3-legend-js, phase: generate-resources)	pom.xml	/edgent-console-servlets
line 125	Maven Project Build Lifecycle Mapping Problem
    > 
    > 
    > Also, earlier mods cause the following warnings in Eclipse that would be good to
eliminate:
    > 
    > Access "/Users/dlaboss/git/dutz-incubator-edgent/console/server/../../src/main/appended-resources/licenses"
directory outside of project base directory. (org.apache.maven.plugins:maven-resources-plugin:2.7:resources:default-resources:process-resources)
pom.xml	/edgent-console-server	line 1	Maven Build Participant Problem
    > 
    > Access "/Users/dlaboss/git/dutz-incubator-edgent/console/servlets/../../src/main/appended-resources/licenses"
directory outside of project base directory. (org.apache.maven.plugins:maven-resources-plugin:2.7:resources:default-resources:process-resources)
pom.xml	/edgent-console-servlets	line 1	Maven Build Participant Problem
    > 
    > Duplicating managed version 2.5.3 for maven-assembly-plugin	pom.xml	/edgent-distribution
line 40	Maven pom Loading Problem
    > 
    > Thanks!
    > — Dale
    
    

Mime
View raw message