Mailing-List: contact dev-help@edgent.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@edgent.apache.org
From: Dale LaBossiere <dml.apache@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\))
Subject: Re: What's left to do for Maven migration?
Date: Wed, 9 Aug 2017 09:29:36 -0400
References: <25E27EFB-DC63-4858-9CDA-978018A6DCC0@c-ware.de>
 <8C3EA0E0-5205-4801-A512-3075B8EA5D74@gmail.com>
 <EE567898-9403-440E-846C-CB0002B06229@c-ware.de>
 <876BA660-9EA0-47AE-954D-73C77C922681@c-ware.de>
 <79F1D6F6-B28C-4B98-8A46-242EC9A7DB8D@c-ware.de>
 <5C10FD9C-58DA-4980-9394-B4C8BA1B7FD5@gmail.com>
 <382A5E28-FBF1-408C-BD02-B6FAF3F51F21@c-ware.de>
 <CE9FC597-9753-4A36-A138-023E5FAD2A88@gmail.com>
 <FEEDA1DC-C7CA-45BF-8F02-083BB1D6C397@c-ware.de>
To: dev@edgent.apache.org
In-Reply-To: <FEEDA1DC-C7CA-45BF-8F02-083BB1D6C397@c-ware.de>
Message-Id: <74549A01-8B95-4525-8232-726F0680FA24@gmail.com>
archived-at: Wed, 09 Aug 2017 13:29:45 -0000

Sounds reasonable. Thanks!

=E2=80=94 Dale

> On Aug 9, 2017, at 2:55 AM, Christofer Dutz =
<christofer.dutz@c-ware.de> wrote:
>=20
> Hi Dale,
>=20
> I guess it would be a lot easier to split. This way the work of =
splitting has to be done exactly once and from then on everything is =
super easy. The other way around it doesn=E2=80=99t cost anything to =
setup, but the costs of releasing increase dramatically due to the =
requirement to cherry pick commits.
>=20
> Sure, I could request the things needed and handle the execution. But =
I quess that would be a runner-up task after merging back the maven =
changes first.
>=20
> Chris
>=20
>=20
> Am 08.08.17, 22:11 schrieb "Dale LaBossiere" <dml.apache@gmail.com>:
>=20
>    In the near term I was thinking/hoping that simply separating the =
samples and the core *source release bundles* would be less disruptive =
than, though a necessary precursor to, migrating the samples to a =
separate repo.
>=20
>    If it=E2=80=99s simply much easier, given maven and the release =
plugins, to have a separate repos to achieve separate core / samples =
source release bundles, then maybe that needs to be considered now.  =
Chris, would you be able to set that up?  Maybe give it a thought while =
I=E2=80=99m out.=20
>=20
>    Thanks!
>    =E2=80=94 Dale
>=20
>> On Aug 8, 2017, at 10:14 AM, Christofer Dutz =
<christofer.dutz@c-ware.de> wrote:
>>=20
>> Hi Dale,
>>=20
>> great you=E2=80=99re looking into this issue =E2=80=A6 I would have =
to work myself into the topic a little more in order to address that.
>>=20
>> Regarding the samples issues: I would strongly suggest to request a =
separate GIT repo for the samples. While it is possible to keep them in =
there, there are a lot of issues that have to be dealt with this way.
>> First of all you have to exclude stuff from rat (as you have seen), =
then you have to exclude stuff from the releases (as you have seen too), =
but probably the most annoying thing is dealing with releasing in GIT.
>> Having mixed repos, we would have several tags in one repo reflecting =
releases of Edgent and the samples. While I would treat this fact as =
=E2=80=9Cannoying=E2=80=9D at most, the main problem will be merging the =
parts that are part of the release back to the master branch.
>>=20
>> If the repos are separate, all you have to do is merge the tagged =
release revision back to master and all is good. In case of a mixed =
repo, you will have to do a lot of manual merging and cherry picking.
>>=20
>> So I would opt for splitting up the repos and creating nicely =
separated build configs for both.
>>=20
>> Repos are cheap at the ASF :-)
>>=20
>> Chris
>>=20
>>=20
>>=20
>>=20
>> Am 08.08.17, 15:59 schrieb "Dale LaBossiere" <dml.apache@gmail.com>:
>>=20
>>   That explains the failure in the SVT test in travis.  Ugh.  :-(
>>=20
>>   I=E2=80=99ll look into it.  By the end of the day I=E2=80=99ll =
either fix it or temporarily disable the SVT test (and add a tracking =
item to the wiki page).
>>=20
>>   As I noted in the PR, the top-level pom.xml has comments (3?) =
related to the handling of the samples project.  When you get a chance =
could you look at those and perhaps identify what needs to be done to =
address them?  Thanks!
>>=20
>>   =E2=80=94 Dale
>>=20
>>=20
>>> On Aug 8, 2017, at 9:36 AM, Christofer Dutz =
<christofer.dutz@c-ware.de> wrote:
>>>=20
>>> Hi all,
>>>=20
>>> I just pulled in Dales changes to my forks branch. I like excluding =
the examples from the core build. However there is one problem as the =
test/svt project has a test dependency on the samples/apps project. If =
this is excluded, the build will probably fail.
>>> I would suggest to adjust the test to not rely on a sample. Hereby I =
could remove the top most issue in the =E2=80=9Cproblems=E2=80=9D =
document.
>>>=20
>>> Should we leave everything the way it currently is, or should I =
create a feature/maven branch in the Edgent repo? I=E2=80=99m fine with =
both options. If anyone else needs write access to my fork, just send me =
an email.=20
>>>=20
>>> Chris
>>>=20
>>>=20
>>> Am 23.07.17, 20:05 schrieb "Christofer Dutz" =
<christofer.dutz@c-ware.de>:
>>>=20
>>>  Hi,
>>>=20
>>>  I just pushed a change that includes my improved jar-free version =
of the maven-wrapper that should be 100% compliant with Apache Release =
rules.
>>>  It=E2=80=99s currently the exact same version I submitted as =
pull-request for the maven-wrapper project, but as the scripts are =
duplicated and checked in anyway, I thought I=E2=80=99d just go ahead =
and add them to Edgent.
>>>  My first tests were perfect :-)
>>>=20
>>>  So now, if you checked out Edgent and have JAVA_HOME set all you =
need to do, is run:=20
>>>=20
>>>  ./mvnw clean install
>>>=20
>>>  and it will download the maven version, install it and use it. So =
you can now reduce the requirements to having Java 8 Installed.
>>>=20
>>>  One thing I noticed today =E2=80=93 as I=E2=80=99m currently =
setting up my new laptop =E2=80=93 is that it=E2=80=99s no longer =
trivial to get a Java 7 JDK.=20
>>>  I will try to figure out how to setup the toolchain to support =
building Java 7 with only Java 8 in the next few days =E2=80=A6 =
hopefully it will be as easy as defining a java 7 JDK which points to =
the Java 8 version.
>>>=20
>>>  Chris
>>>=20
>>>=20
>>>=20
>>>  Am 19.07.17, 11:13 schrieb "Christofer Dutz" =
<christofer.dutz@c-ware.de>:
>>>=20
>>>      By the way =E2=80=A6 my pull request for the maven-wrapper is =
currently being finalized =E2=80=A6 hopefully this will be finished soon =
and then it will make things even easier ;-)
>>>      https://github.com/takari/maven-wrapper/pull/60
>>>=20
>>>      Chris
>>>=20
>>>      Am 17.07.17, 16:03 schrieb "Dale LaBossiere" =
<dml.apache@gmail.com>:
>>>=20
>>>          Sorry for that confusion.  There are so many details to =
track / deal with.
>>>=20
>>>          The Issues / TODOs in [1] all need to be reviewed and need =
resolutions.  Can we just work from that? (marking done items as such, =
including the resolution, and then just doing a strikethrough it the =
resolved item)
>>>=20
>>>          Right now, I think dealing with the binary release bundle =
and samples are the highest priority / largest unknowns.
>>>=20
>>>          Thanks for all your continued diligence!
>>>=20
>>>          =E2=80=94 Dale
>>>=20
>>>> On Jul 17, 2017, at 2:43 AM, Christofer Dutz =
<christofer.dutz@c-ware.de> wrote:
>>>>=20
>>>> Hi guys,
>>>>=20
>>>> So right now, I sort of lost track of what=E2=80=99s still left to =
do on your wish list for a successful maven migration.
>>>> If someone could compile a list of things to do, I would gladly =
work on those issues. Must admit that I lost track a little on the =
confluence page.
>>>>=20
>>>> Chris
>>>=20
>>>=20
>>>=20
>>>=20
>>>=20
>>>=20
>>>=20
>>=20
>>=20
>>=20
>=20
>=20
>=20