edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-edgent pull request #315: [EDGENT-428] Adding support for csv in M...
Date Fri, 04 Aug 2017 18:44:10 GMT
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-edgent/pull/315#discussion_r131459749
  
    --- Diff: utils/metrics/src/main/java/org/apache/edgent/metrics/MetricsSetup.java ---
    @@ -111,6 +144,25 @@ private MBeanServer mbeanServer() {
             }
             return mBeanServer;
         }
    +
    +    /**
    +     * Creates a default directory for metrics.
    +     * 
    +     * @return directory.getPath()
    +     */
    +    private String createDefaultDirectory() {
    +        Path currentRelativePath = Paths.get("");
    +        String pathMetrics = currentRelativePath.toAbsolutePath().toString() + FOLDER_METRICS;
    +        File directory = new File(pathMetrics);
    +        
    +        if (!directory.mkdirs()) {
    +            // Log: "Could not create the directory log"
    --- End diff --
    
    I'm going to merge this now.  Thomas, when you get a chance it would be great to add the
logging.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message