edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-edgent pull request #314: Adding support for csv in MetricsSetup
Date Wed, 19 Jul 2017 16:55:49 GMT
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-edgent/pull/314#discussion_r128304858
  
    --- Diff: utils/metrics/src/main/java/org/apache/edgent/metrics/MetricsSetup.java ---
    @@ -85,6 +92,25 @@ public MetricsSetup startJMXReporter(String jmxDomainName) {
             reporter.start();
             return this;
         }
    +
    +    /**
    +     * Starts the metric {@code CsvReporter}. If no MBeanServer was set, use the
    +     * virtual machine's platform MBeanServer.
    +     * 
    +     * @param pathMetrics
    --- End diff --
    
    Sorry, what I was trying to ask does this javadoc need to be adjusted now?  Can you still
supply "null" or a path to a non-existant file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message