edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrisdutz <...@git.apache.org>
Subject [GitHub] incubator-edgent pull request #309: Migration of the Edgent project to be ab...
Date Sat, 03 Jun 2017 12:39:14 GMT
Github user chrisdutz commented on a diff in the pull request:

    https://github.com/apache/incubator-edgent/pull/309#discussion_r119985909
  
    --- Diff: analytics/math3/pom.xml ---
    @@ -0,0 +1,68 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +
    +  Licensed to the Apache Software Foundation (ASF) under one or more
    +  contributor license agreements.  See the NOTICE file distributed with
    +  this work for additional information regarding copyright ownership.
    +  The ASF licenses this file to You under the Apache License, Version 2.0
    +  (the "License"); you may not use this file except in compliance with
    +  the License.  You may obtain a copy of the License at
    +
    +      http://www.apache.org/licenses/LICENSE-2.0
    +
    +  Unless required by applicable law or agreed to in writing, software
    +  distributed under the License is distributed on an "AS IS" BASIS,
    +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  See the License for the specific language governing permissions and
    +  limitations under the License.
    +
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.edgent.analytics</groupId>
    +    <artifactId>analytics</artifactId>
    +    <version>1.2.0-SNAPSHOT</version>
    --- End diff --
    
    Actually not. Especially the parent is the only place where a variable can't be used.
But in maven the version number of the all artifacts in the same reactor (collection of maven
modules in one build) is usually explicitly written as the maven-release-plugin takes care
of updating all the version numbers. The only place it tends to have problems with is when
referencing versions in the plugin configuration. That's why I used variables in the maven-dependency-plugin
configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message