edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-edgent pull request #306: [Edgent-409] add analytics.math3.Aggrega...
Date Thu, 20 Apr 2017 15:59:53 GMT
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-edgent/pull/306#discussion_r112492352
  
    --- Diff: analytics/math3/src/main/java/org/apache/edgent/analytics/math3/UnivariateAggregator.java
---
    @@ -0,0 +1,47 @@
    +/*
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +*/
    +package org.apache.edgent.analytics.math3;
    +
    +/**
    + * Univariate aggregator for tuples.
    + * This is the runtime implementation interface
    + * of {@link UnivariateAggregate} defined aggregate.
    + */
    +public interface UnivariateAggregator {
    +  
    +    UnivariateAggregate getAggregate();
    +    
    +    /**
    +     * Clear the aggregator to prepare for a new aggregation.
    +     * @param n Number of tuples to be aggregated.
    +     */
    +    void clear(int n);
    +    
    +    /**
    +     * Add a value to the aggregation. 
    +     * @param value Value to be added.
    +     */
    +    void increment(double value);
    +    
    +    /**
    +     * Get the aggregation result.  It may be a NaN (empty collection, etc) or Infinite
value.
    +     * @return the result
    +     */
    +    double getResult();
    --- End diff --
    
    fyi, getResult() is different style than the "add to result" JsonUnivariateAggregator.result(...,
JsonObject).
    Having getResult(), rather than "add to result" result(ResultMap), enables subsequent
    of UnivariateAggregate/UnivariateAggregator by JsonAnalytics without requiring 
    its implementation to use ResultMap.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message