edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-edgent pull request #280: [Edgent-374] [COMMENTS?] IotGateway [ci-...
Date Wed, 01 Feb 2017 20:42:32 GMT
GitHub user dlaboss opened a pull request:

    https://github.com/apache/incubator-edgent/pull/280

    [Edgent-374] [COMMENTS?] IotGateway [ci-skip]

    Add IotGateway
    Add IotDevice.{getDeviceType(),getDeviceId(),CMD_DEVICE}
    
    These IotDevice changes break existing IotDevice implementations but in
    practice this won't be a problem - its highly unlikely any IotDevice
    implementations exist outside of this repository (and adapting is
    trivial).  "default" can't be used due to support for Java7/Android.  
    
    Other schemes are possible that avoid this but they don't model things
    as well (an IotDevice really does have an Id), introduce even more types
    (e.g., a IotGatewayConnectedDevice), and/or are less convenient to use.
    e.g., those new IotDevice methods could be migrated to IotGateway -
    IotGateway.getDeviceId(IotDevice).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlaboss/incubator-edgent edgent377-iotGateway

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-edgent/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #280
    
----
commit ca0ee386e2596448b036b6fb66a53fac4ef2aa9d
Author: Dale LaBossiere <dlaboss@us.ibm.com>
Date:   2017-02-01T20:39:48Z

    [Edgent-374] [COMMENTS?] IotGateway [ci-skip]
    
    Add IotGateway
    Add IotDevice.{getDeviceType(),getDeviceId(),CMD_DEVICE}
    
    These IotDevice changes break existing IotDevice implementations but in
    practice this won't be a problem - its highly unlikely any IotDevice
    implementations exist outside of this repository (and adapting is
    trivial).  "default" can't be used due to support for Java7/Android.  
    
    Other schemes are possible that avoid this but they don't model things
    as well (an IotDevice really does have an Id), introduce even more types
    (e.g., a IotGatewayConnectedDevice), and/or are less convenient to use.
    e.g., those new IotDevice methods could be migrated to IotGateway -
    IotGateway.getDeviceId(IotDevice).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message