edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
Date Mon, 09 Jan 2017 20:35:58 GMT

    [ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812776#comment-15812776
] 

ASF GitHub Bot commented on EDGENT-327:
---------------------------------------

Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95240254
  
    --- Diff: build.sh ---
    @@ -1,6 +1,8 @@
     set -e
     cd site
     jekyll build -d ../content_tmp
    +# Remove dangling references to the DejaVu fonts in the Javadoc stylesheets
    +sed -i "" "/^@import/d; s/'DejaVu Sans',//g; s/'DejaVu Sans Mono',//g; s/'DejaVu Serif',//g"
../content_tmp/javadoc/*/stylesheet.css
    --- End diff --
    
    Removing all imports vs only those associated with dejavu.css seems a little heavy handed?
    Maybe also only have a single pattern to match any current, or future, DejaVu font spec?
 Sed seems to lack a non-greedy specifier but the following seems to work s/'DejaVu[^']*',*//g
 -- match everything starting with 'DejaVu and all chars up the first single quote, and that
single quote, and an optional comma (i.e., if it came at the end of the font spec)


> some http urls in the website prevent full local testing
> --------------------------------------------------------
>
>                 Key: EDGENT-327
>                 URL: https://issues.apache.org/jira/browse/EDGENT-327
>             Project: Edgent
>          Issue Type: Task
>          Components: Web Site
>            Reporter: Dale LaBossiere
>            Assignee: Queenie Ma
>            Priority: Trivial
>
> If you create a local / test instance of the website (e.g., "jekyll server") all of the
javadoc related links go to the live website.
> site/_config.yml defines docurl which is used in many places. See the note there about
issues encountered when I tried changing it from a http url to a / url... though overall it
seemed to work.
> Also the javadoc "latest", 1.0.0, ... links in site/_data/mydoc/mydoc_topnav.yml are
http links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message