edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-edgent-website pull request #89: [EDGENT-327] Use local Javadoc UR...
Date Mon, 09 Jan 2017 20:35:51 GMT
Github user dlaboss commented on a diff in the pull request:

    --- Diff: build.sh ---
    @@ -1,6 +1,8 @@
     set -e
     cd site
     jekyll build -d ../content_tmp
    +# Remove dangling references to the DejaVu fonts in the Javadoc stylesheets
    +sed -i "" "/^@import/d; s/'DejaVu Sans',//g; s/'DejaVu Sans Mono',//g; s/'DejaVu Serif',//g"
    --- End diff --
    Removing all imports vs only those associated with dejavu.css seems a little heavy handed?
    Maybe also only have a single pattern to match any current, or future, DejaVu font spec?
 Sed seems to lack a non-greedy specifier but the following seems to work s/'DejaVu[^']*',*//g
 -- match everything starting with 'DejaVu and all chars up the first single quote, and that
single quote, and an optional comma (i.e., if it came at the end of the font spec)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message