edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-edgent pull request #229: Fix publish by ignoring platform project...
Date Mon, 07 Nov 2016 18:46:30 GMT
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-edgent/pull/229#discussion_r86837398
  
    --- Diff: build.gradle ---
    @@ -621,6 +623,7 @@ subprojects {
     
       // support for 'gradle publishToMavenLocal' etc 
       // TODO publishing test.{fvt,svt} and samples ... doesn't seem desirable? e.g., we're
excluding test.{fvt,svt} jars from the tgz
    +  if(!project.group.equals("edgent.platform")){
    --- End diff --
    
    Thanks for your contribution!
    Rather than duplicate the "edgent.platform" specific conditionalization here, instead,
how about making it more general?
    ```if (project.pluginManager.hasPlugin('publishing')) {```
    
    At a higher level, I think I wish there were a way to address the problem without project-specific
conditionalization in the root build.gradle.  Do you have any thoughts on an approach where
specific sub projects build.gradle (like platform/*/build.gradle) could do something to override
the "typical/default subproject" behavior in the root build.gradle subprojects processing?
 e.g., doing something like setting a "omitPublishingPlugin" property (that the "default"
subproject processing checks) or somehow nullifying the "default" publishing configuration
that's created. ???


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message