edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuanyue202 <...@git.apache.org>
Subject [GitHub] incubator-edgent pull request #181: Enable Edgent to publish to maven reposi...
Date Tue, 23 Aug 2016 15:02:06 GMT
Github user xuanyue202 commented on a diff in the pull request:

    https://github.com/apache/incubator-edgent/pull/181#discussion_r75884857
  
    --- Diff: build.gradle ---
    @@ -29,6 +29,21 @@ allprojects {
     
     apply plugin: 'java'
     
    +/* SET PROJECT INFO for all artifacts */
    +assert hasProperty('version')   // See version in gradle.properties.
    +System.out.println("version=${version}")
    --- End diff --
    
    You are right, I did not take care of version well. Should do it using the build_version.

    Regarding to group, there is another question. I think the group for edgent is a little
weird. It seems to me that a better setting is to unify all groups to org.apache.edgent instead
of having different group ids across the project. But that may involve some additional work,
plus I am not sure if there are special reasons for quarks to do so, I just leave it as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message