edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-quarks pull request #146: Fixed time-based batch windowing issue
Date Tue, 21 Jun 2016 23:48:03 GMT
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/146#discussion_r67973272
  
    --- Diff: api/window/src/main/java/quarks/window/Policies.java ---
    @@ -69,11 +71,11 @@ Licensed to the Apache Software Foundation (ASF) under one
             
             // Can't use lambda since state is required
             return new BiConsumer<Partition<T,K,L>, T>() {
    -            private boolean first = true;
    +            private Set<Partition<T,K,L>> initialized_partitions = new HashSet<>();
    --- End diff --
    
    needs to be a synchronized set


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message