Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7BD8C200AE2 for ; Fri, 27 May 2016 14:40:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7ADB5160A12; Fri, 27 May 2016 12:40:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C283716099F for ; Fri, 27 May 2016 14:40:16 +0200 (CEST) Received: (qmail 63202 invoked by uid 500); 27 May 2016 12:40:16 -0000 Mailing-List: contact dev-help@quarks.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quarks.incubator.apache.org Delivered-To: mailing list dev@quarks.incubator.apache.org Received: (qmail 63191 invoked by uid 99); 27 May 2016 12:40:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2016 12:40:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7986DC9F72 for ; Fri, 27 May 2016 12:40:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6M2zk7PZTmiE for ; Fri, 27 May 2016 12:40:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 61BB05F60D for ; Fri, 27 May 2016 12:40:14 +0000 (UTC) Received: (qmail 61392 invoked by uid 99); 27 May 2016 12:40:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2016 12:40:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1D6752C1F6F for ; Fri, 27 May 2016 12:40:13 +0000 (UTC) Date: Fri, 27 May 2016 12:40:13 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@quarks.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (QUARKS-188) Console metric propagation shouldn't traverse non-injected metric ops MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 27 May 2016 12:40:17 -0000 [ https://issues.apache.org/jira/browse/QUARKS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304010#comment-15304010 ] ASF GitHub Bot commented on QUARKS-188: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/incubator-quarks/pull/124 > Console metric propagation shouldn't traverse non-injected metric ops > --------------------------------------------------------------------- > > Key: QUARKS-188 > URL: https://issues.apache.org/jira/browse/QUARKS-188 > Project: Quarks > Issue Type: Task > Components: Console > Reporter: Dale LaBossiere > Assignee: Dale LaBossiere > Priority: Minor > > QUARKS-22 / PR-116 added "metric propagation" so edge segments get proper width rendering and edge hovers report metrics across injected ops. > The traversal code was including (non-injected) CounterOp and RateMetric oplets which is undesirable since each such oplet is included in the retrieved "counter metrics" hence each already ended up setting its adjecent edges' metric value. Hence traversing them too is unnecessary / extra work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)