Mailing-List: contact dev-help@quarks.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quarks.incubator.apache.org
Date: Mon, 9 May 2016 20:14:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@quarks.incubator.apache.org
Message-ID: <JIRA.12955105.1459460564000.145804.1462824852888@Atlassian.JIRA>
In-Reply-To: <JIRA.12955105.1459460564000@Atlassian.JIRA>
References: <JIRA.12955105.1459460564000@Atlassian.JIRA> <JIRA.12955105.1459460564789@arcas>
Subject: [jira] [Commented] (QUARKS-96) Add an HTTP POST utility method.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 09 May 2016 20:14:18 -0000


    [ https://issues.apache.org/jira/browse/QUARKS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276939#comment-15276939 ] 

ASF GitHub Bot commented on QUARKS-96:
--------------------------------------

Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/106#discussion_r62564599
  
    --- Diff: connectors/http/src/main/java/quarks/connectors/http/runtime/HttpRequester.java ---
    @@ -69,16 +84,35 @@ public R apply(T t) {
             String m = method.apply(t);
             String uri = url.apply(t);
             HttpUriRequest request;
    +        
             switch (m) {
    -        case HttpGet.METHOD_NAME:          
    +        
    +        case HttpGet.METHOD_NAME:
                 request = new HttpGet(uri);
                 break;
    -        case HttpDelete.METHOD_NAME:          
    +        case HttpDelete.METHOD_NAME:
                 request = new HttpDelete(uri);
                 break;
    +        case HttpPost.METHOD_NAME:
    +            request = new HttpPost(uri);
    +            break;
    +        case HttpPut.METHOD_NAME:
    +            request = new HttpPut(uri);
    --- End diff --
    
    Adding Put seems like a good idea.  Of course that then begs the question: should there also be {put,delete}Json()? (and tests)  :-)


> Add an HTTP POST utility method.
> --------------------------------
>
>                 Key: QUARKS-96
>                 URL: https://issues.apache.org/jira/browse/QUARKS-96
>             Project: Quarks
>          Issue Type: Improvement
>          Components: Connectors
>            Reporter: Daniel John Debrunner
>            Assignee: Dale LaBossiere
>              Labels: newbie
>
> HTTPStreams.requests can support any type of request but it would be useful to have a utility method for POST requests, similar to getJson - i.e., a postJson()


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)