Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0BBAA2004CA for ; Wed, 11 May 2016 15:18:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0A3751602BF; Wed, 11 May 2016 13:18:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 541591602BE for ; Wed, 11 May 2016 15:18:21 +0200 (CEST) Received: (qmail 49697 invoked by uid 500); 11 May 2016 13:18:20 -0000 Mailing-List: contact dev-help@quarks.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quarks.incubator.apache.org Delivered-To: mailing list dev@quarks.incubator.apache.org Received: (qmail 49683 invoked by uid 99); 11 May 2016 13:18:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 13:18:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CABB2C32CD for ; Wed, 11 May 2016 13:18:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.436 X-Spam-Level: X-Spam-Status: No, score=-5.436 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.416] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id x9p-I2aDmltA for ; Wed, 11 May 2016 13:18:17 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 827715F1E3 for ; Wed, 11 May 2016 13:18:16 +0000 (UTC) Received: (qmail 49671 invoked by uid 99); 11 May 2016 13:18:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 13:18:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 729ACDFC77; Wed, 11 May 2016 13:18:15 +0000 (UTC) From: dlaboss To: dev@quarks.incubator.apache.org Reply-To: dev@quarks.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-quarks pull request: [WIP] QUARKS-96: postJson in HttpSt... Content-Type: text/plain Message-Id: <20160511131815.729ACDFC77@git1-us-west.apache.org> Date: Wed, 11 May 2016 13:18:15 +0000 (UTC) archived-at: Wed, 11 May 2016 13:18:22 -0000 Github user dlaboss commented on a diff in the pull request: https://github.com/apache/incubator-quarks/pull/106#discussion_r62845553 --- Diff: connectors/http/src/main/java/quarks/connectors/http/HttpStreams.java --- @@ -38,12 +44,110 @@ Licensed to the Apache Software Foundation (ASF) under one */ public class HttpStreams { + /** + * Make an HTTP GET request with JsonObject.
+ * + * Method specifically works with JsonObjects. For each JsonObject in the stream, + * HTTP GET request is executed on provided uri. As a result, Response is added to + * the response TStream. + *
+ * + * Sample usage:
+ * + * 
    +     * {@code
    +     *     final String url = "http://httpbin.org/get?";
    +     *     JsonObject request1 = new JsonObject();
    +     *     request1.addProperty("a", "abc");
    +     *     request1.addProperty("b", "42");
    +     *     TStream rc = HttpStreams.getJson(
    +     *             topology.collection(Arrays.asList(request1)),
    +     *             HttpClients::noAuthentication,
    +     *             t -> url + "a=" + t.get("a").getAsString() + "&b="
    +     *                     + t.get("b").getAsString());
    +     * }
    +     *
+ *
+ * See HttpTest for example. + *
+ * @param stream - JsonObject TStream. + * @param clientCreator - CloseableHttpClient supplier preferably created using {@link HttpClients} + * @param uri - URI function which returns URI string + * @return TStream of JsonObject which contains responses of GET requests + * + * @see HttpStreams#requests(TStream, Supplier, Function, Function, BiFunction) + */ public static TStream getJson(TStream stream, Supplier clientCreator, Function uri) { return HttpStreams.requests(stream, clientCreator, - t -> HttpGet.METHOD_NAME, uri, HttpResponders.json()); + t -> HttpGet.METHOD_NAME, uri, HttpResponders.json()); + } + + public static TStream deleteJson(TStream stream, --- End diff -- javadoc for {delete,put}Json()? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---