edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QUARKS-48) Generate JavaDoc for website
Date Tue, 17 May 2016 14:14:13 GMT

    [ https://issues.apache.org/jira/browse/QUARKS-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286685#comment-15286685
] 

ASF GitHub Bot commented on QUARKS-48:
--------------------------------------

Github user Cazen commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks-website/pull/62#discussion_r63529083
  
    --- Diff: site/_includes/header.html ---
    @@ -98,7 +98,7 @@
                           <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button"
aria-haspopup="true" aria-expanded="false">Documentation</a>
                           <ul class="dropdown-menu">
                             <li><a href="docs/home">Documentation Home</a></li>
    -                        <li><a href="{{ site.projurl }}/docs/javadoc/index.html">Javadoc</a></li>
    --- End diff --
    
    Thank you @dlaboss for review and good pointing.
    
    - I agree using properties is much clearer rather than hard coding value. I will replace
javadoc-related-url all with using properties in next day.
    - We can change ```Quarks``` to ```{{ site.projname }}``` but it has been used too many
times. I worried about it may cause readability reduction. But if you mean "Nested Property"(I'm
not sure how I can say in english.. It something like ```projname:quarks``` -> ```url:
http://%{projname}.incubator.apache.org``` in define properties phase) , then it looks very
helpful


> Generate JavaDoc for website
> ----------------------------
>
>                 Key: QUARKS-48
>                 URL: https://issues.apache.org/jira/browse/QUARKS-48
>             Project: Quarks
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Cazen Lee
>
> I'm not sure but it seems that Javadoc branch does not exist.
> I think we can make JavaDoc branch like below:
> https://github.com/quarks-edge/quarks/tree/gh-pages



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message