edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cazen <...@git.apache.org>
Subject [GitHub] incubator-quarks-website pull request: [QUARKS-48] Generate JavaDo...
Date Tue, 17 May 2016 14:13:59 GMT
Github user Cazen commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks-website/pull/62#discussion_r63529083
  
    --- Diff: site/_includes/header.html ---
    @@ -98,7 +98,7 @@
                           <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button"
aria-haspopup="true" aria-expanded="false">Documentation</a>
                           <ul class="dropdown-menu">
                             <li><a href="docs/home">Documentation Home</a></li>
    -                        <li><a href="{{ site.projurl }}/docs/javadoc/index.html">Javadoc</a></li>
    --- End diff --
    
    Thank you @dlaboss for review and good pointing.
    
    - I agree using properties is much clearer rather than hard coding value. I will replace
javadoc-related-url all with using properties in next day.
    - We can change ```Quarks``` to ```{{ site.projname }}``` but it has been used too many
times. I worried about it may cause readability reduction. But if you mean "Nested Property"(I'm
not sure how I can say in english.. It something like ```projname:quarks``` -> ```url:
http://%{projname}.incubator.apache.org``` in define properties phase) , then it looks very
helpful


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message