edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-quarks pull request: [WIP] QUARKS-96: postJson in HttpSt...
Date Mon, 09 May 2016 20:13:40 GMT
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/106#discussion_r62564599
  
    --- Diff: connectors/http/src/main/java/quarks/connectors/http/runtime/HttpRequester.java
---
    @@ -69,16 +84,35 @@ public R apply(T t) {
             String m = method.apply(t);
             String uri = url.apply(t);
             HttpUriRequest request;
    +        
             switch (m) {
    -        case HttpGet.METHOD_NAME:          
    +        
    +        case HttpGet.METHOD_NAME:
                 request = new HttpGet(uri);
                 break;
    -        case HttpDelete.METHOD_NAME:          
    +        case HttpDelete.METHOD_NAME:
                 request = new HttpDelete(uri);
                 break;
    +        case HttpPost.METHOD_NAME:
    +            request = new HttpPost(uri);
    +            break;
    +        case HttpPut.METHOD_NAME:
    +            request = new HttpPut(uri);
    --- End diff --
    
    Adding Put seems like a good idea.  Of course that then begs the question: should there
also be {put,delete}Json()? (and tests)  :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message