edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cazen <...@git.apache.org>
Subject [GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
Date Mon, 09 May 2016 14:24:58 GMT
Github user Cazen commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/109#discussion_r62506139
  
    --- Diff: api/topology/src/test/java/quarks/test/topology/PlumbingTest.java ---
    @@ -601,4 +602,66 @@ public void testParallel() throws Exception {
     //            actDuration < 0.5 * expMinSerialDuration);
     //    }
     
    -}
    +    @Test
    +    public void testGate() throws Exception {
    +        // Timing variances on shared machines can cause this test to fail
    --- End diff --
    
    Hi @dlaboss 
    Sorry for that. At first time I was planning to make test with PlumbingStreams.blockingDelay
(similar to the testBlockingDelay) However, plans changed but the line did not erased.
    I will erase immediately "assumeTrue" line in two Testcase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message