edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlaboss <...@git.apache.org>
Subject [GitHub] incubator-quarks pull request: [QUARKS-166] Add Gate plumbing
Date Mon, 09 May 2016 14:01:32 GMT
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/109#discussion_r62502145
  
    --- Diff: api/topology/src/test/java/quarks/test/topology/PlumbingTest.java ---
    @@ -601,4 +602,66 @@ public void testParallel() throws Exception {
     //            actDuration < 0.5 * expMinSerialDuration);
     //    }
     
    -}
    +    @Test
    +    public void testGate() throws Exception {
    +        // Timing variances on shared machines can cause this test to fail
    --- End diff --
    
    Does this "timing variances" failure condition actually happen?  I can't imagine how it
could.  Same with 2nd test case (though may have to increase test-tmo beyone 1sec. for that
one).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message