Return-Path: 
 <dev-return-1968-apmail-quarks-dev-archive=quarks.apache.org@quarks.incubator.apache.org>
X-Original-To: apmail-quarks-dev-archive@minotaur.apache.org
Delivered-To: apmail-quarks-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2525F196C8
	for <apmail-quarks-dev-archive@minotaur.apache.org>;
 Mon, 25 Apr 2016 22:42:53 +0000 (UTC)
Received: (qmail 14403 invoked by uid 500); 25 Apr 2016 22:42:53 -0000
Delivered-To: apmail-quarks-dev-archive@quarks.apache.org
Received: (qmail 14388 invoked by uid 500); 25 Apr 2016 22:42:53 -0000
Mailing-List: contact dev-help@quarks.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@quarks.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@quarks.incubator.apache.org>
List-Post: <mailto:dev@quarks.incubator.apache.org>
List-Id: <dev.quarks.incubator.apache.org>
Reply-To: dev@quarks.incubator.apache.org
Delivered-To: mailing list dev@quarks.incubator.apache.org
Received: (qmail 14377 invoked by uid 99); 25 Apr 2016 22:42:52 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO
 spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 22:42:52 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org)
 with ESMTP id 6A622C0227
	for <dev@quarks.apache.org>; Mon, 25 Apr 2016 22:42:52 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx2-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new,
 port 10024)
	with ESMTP id ZS0PsHaWOpQ1 for <dev@quarks.apache.org>;
	Mon, 25 Apr 2016 22:42:51 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP
 id A791E5F1F7
	for <dev@quarks.incubator.apache.org>; Mon, 25 Apr 2016 22:42:50 +0000 (UTC)
Received: (qmail 14362 invoked by uid 99); 25 Apr 2016 22:42:49 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 22:42:49 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id C3723DFDE3; Mon, 25 Apr 2016 22:42:49 +0000 (UTC)
From: vdogaru <git@git.apache.org>
To: dev@quarks.incubator.apache.org
Reply-To: dev@quarks.incubator.apache.org
References: <git-pr-86-incubator-quarks@git.apache.org>
In-Reply-To: <git-pr-86-incubator-quarks@git.apache.org>
Subject: [GitHub] incubator-quarks pull request: [QUARKS-131] [REVIEW] supply
 an ali...
Content-Type: text/plain
Message-Id: <20160425224249.C3723DFDE3@git1-us-west.apache.org>
Date: Mon, 25 Apr 2016 22:42:49 +0000 (UTC)

Github user vdogaru commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/86#discussion_r61002673
  
    --- Diff: api/oplet/src/main/java/quarks/oplet/core/PeriodicSource.java ---
    @@ -47,8 +48,8 @@ public void initialize(OpletContext<Void, T> context) {
         public synchronized void start() {
             ControlService cs = getOpletContext().getService(ControlService.class);
             if (cs != null)
    -            cs.registerControl("periodic", getOpletContext().uniquify(getClass().getSimpleName()), 
    -                    getAlias(), PeriodicMXBean.class, this);
    +            cs.registerControl(TStream.TYPE, getOpletContext().uniquify(getClass().getSimpleName()), 
    --- End diff --
    
    Would it make sense to register the control against a class type rather than a String?  Instead of:
    
    `<T> String registerControl(String type, String id, String alias, Class<T> controlInterface, T control);` where 
    the `type` parameter identifies the type of the control MBean, use:
    
    `<T> String registerControl(Class<?> type, String id, String alias, Class<T> controlInterface, T control);` where the `type` parameter is the type of object controlled by the MBean.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---