edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdogaru <...@git.apache.org>
Subject [GitHub] incubator-quarks pull request: [QUARKS-131] [REVIEW] supply an ali...
Date Wed, 20 Apr 2016 19:22:12 GMT
Github user vdogaru commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/86#discussion_r60471221
  
    --- Diff: api/topology/src/main/java/quarks/topology/TStream.java ---
    @@ -443,7 +443,7 @@ else if (WARNING.equals(lr.getLevel()))
         Set<String> getTags(); 
         
         /**
    -     * Add an alias for the stream.
    +     * Set an alias for the stream.
          * <p>
          * The alias must be unique within the topology.
    --- End diff --
    
    Is the statement "must be unique within the topology" too restrictive? 
    The system registers a control associated with that TStream using ```ControlService.registerControl(String
type, String id, String alias, Class<T> controlInterface, T control)```, where the 'alias'
parameter is TStream's alias. The registration requires that 'alias' is unique within the
context of the control 'type'.  So I could have:
    ```
    TStream<Double> t1  = topology.poll(...);
    t1.alias("foo");
    // At run time, the PeriodicSource oplet registers a PeriodicMXBean with type "periodic"
and alias "foo"
    ...
    TStream<String> t2 = t1.map(...);
    t2.alias("foo");
    // At run time, the Map oplet registers a (hypothetical) MapMXBean with type "map" and
alias "foo"
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message