edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ddebrunner <...@git.apache.org>
Subject [GitHub] incubator-quarks pull request: [QUARKS-124] [REVIEW] add Deadtime ...
Date Tue, 19 Apr 2016 23:23:48 GMT
Github user ddebrunner commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/91#discussion_r60329187
  
    --- Diff: analytics/sensors/src/main/java/quarks/analytics/sensors/Filters.java ---
    @@ -114,4 +114,27 @@ private Filters() {}
     
             return stream.filter(new Deadband<>(value, inBand));
         }
    +    
    +    /**
    +     * A filter that discards tuples received during the "deadtime period"
    --- End diff --
    
    Not English! and too long for the summary that is seen in Javadoc.
    
    Maybe just:
    
    Deadtime filter.
    
    (c.f. Deadband filter)
    
    Then have the following sentences describe what it does.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message