edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cazen <...@git.apache.org>
Subject [GitHub] incubator-quarks-website pull request: Make video dynamically size...
Date Sat, 16 Apr 2016 13:10:28 GMT
Github user Cazen commented on the pull request:

    https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-210812906
  
    Good day @Alex-Cook4 
    
    - Sorry for confusing. I thought there is not frameborder setting in your change because
video's bottom line is not presented. But it's not(And 0 or 1 is right. 3 is mistake). It
seems slightly truncated. Now I think frameborder is no correlation in this problem(unnecessary).
Sorry again.
    - I think this issue related on responsive video issue. In fact, I think there is no problem
with youtube size is automatically adjusted depending on the size of the window and accurately
played with no error. So how about this way like below?
    ```
    <div class="col-lg-6 col-sm-pull-5 col-sm-6">
        <div class="embed-responsive embed-responsive-16by9">
            <iframe class="embed-responsive-item" src="//www.youtube.com/embed/Xqns7yVNDnk"
allowfullscreen></iframe>
        </div>
    </div>
    ```
    - Of course, I'm not an expert on bootstrap. Please tell me if I was wrong or there is
better way to solve this problem. I'm happy to hear that. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message