edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex-Cook4 <...@git.apache.org>
Subject [GitHub] incubator-quarks-website pull request: Make video dynamically size...
Date Fri, 15 Apr 2016 14:28:56 GMT
Github user Alex-Cook4 commented on the pull request:

    https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-210483248
  
    @Cazen good idea on the frameborder! I'm not familiar with frameborder, but as a html
property, it only takes 0|1. I changed it to 1. That gives us: 
    
    ![image](https://cloud.githubusercontent.com/assets/12279352/14564392/fd924b4e-02eb-11e6-990b-32da8cb14a88.png)
    
    What were you thinking with the 3? 
    
    I'm also not very happy with how I did the dynamic sizing since I had to give the outside
dive a defined height:290px in order for the percentages to work. Maybe you're more familiar
with iframes and know a better way? 
    
    
    ```
    <div style="height:290px;" class="col-lg-7 col-sm-pull-5 col-sm-6">  
              <iframe style="width:85%;height:100%" src="//www.youtube.com/embed/Xqns7yVNDnk"
frameborder="1" allowfullscreen></iframe>
    </div>
    ```
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message