edgent-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ddebrunner <...@git.apache.org>
Subject [GitHub] incubator-quarks pull request: Rework IotfSensors to separate Hear...
Date Mon, 04 Apr 2016 14:29:04 GMT
Github user ddebrunner commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/67#discussion_r58384180
  
    --- Diff: samples/connectors/src/main/java/quarks/samples/connectors/iotf/IotfSensors.java
---
    @@ -109,6 +99,31 @@ public static void simulatedSensors(IotDevice device, boolean print)
{
             // with event identifier "sensors".
             device.events(sensors, "sensors", QoS.FIRE_AND_FORGET);
         }
    +    
    +    /**
    +     * Create a heart beat device event with
    +     * identifier {@code heartbeat} to
    +     * ensure there is some immediate output and
    +     * the connection to IoTF happens as soon as possible.
    +     * @param device IoT device
    +     */
    +    public static void heartBeat(IotDevice device, boolean print) {
    --- End diff --
    
    Any thoughts on how this sample method comment could be improved to not promote its use?
It does already state what the purpose of the heartbeat is for this sample.
    
    Not also that a heartbeat device event performs a somewhat different role to KeepAlive/LastWillAndTestament
in that subscribers have visibility to the "I'm still connected" events


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message