eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From asdf2014 <...@git.apache.org>
Subject [GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Date Wed, 31 May 2017 12:15:05 GMT
Github user asdf2014 commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/941#discussion_r119341799
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
---
    @@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
                 velocityEngine = new VelocityEngine();
                 velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
                 velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
    +            velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
    --- End diff --
    
    I think it would be better to put the fully qualified name in the `import` snippet. In
addition, here is a problem that `EagleMailClient` need be refactoring for sloving code duplication,
so, in addition to` alert-engine` module, there `eagle-common` module is also need to be modified.
    
    ```java
    import org.apache.velocity.runtime.log.NullLogChute;
    
    velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message