eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jhsenjaliya <...@git.apache.org>
Subject [GitHub] eagle pull request #925: [EAGLE-1012] Some language level problems in `eagle...
Date Tue, 02 May 2017 05:59:38 GMT
Github user jhsenjaliya commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/925#discussion_r114252915
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert-service/src/main/java/org/apache/eagle/service/alert/resolver/AttributeResolverFactory.java
---
    @@ -43,8 +43,6 @@ public static AttributeResolvable getAttributeResolver(String fieldResolverName,
                     fieldResolvableCache.put(fieldResolverName, instance);
                 } catch (ClassNotFoundException e) {
                     throw new AttributeResolveException("Attribute Resolver in type of "
+ fieldResolverName + " is not found", e);
    -            } catch (InstantiationException | IllegalAccessException e) {
    --- End diff --
    
    instead of removing this, it can be used to describe the error, IDE is suggesting to collapse
the catch block may be because it has identical error msg (throw new AttributeResolveException(e)).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message