Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 70C68200C59 for ; Mon, 17 Apr 2017 10:08:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6F7B9160BAE; Mon, 17 Apr 2017 08:08:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B72E2160B9C for ; Mon, 17 Apr 2017 10:08:44 +0200 (CEST) Received: (qmail 53966 invoked by uid 500); 17 Apr 2017 08:08:44 -0000 Mailing-List: contact issues-help@eagle.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@eagle.apache.org Delivered-To: mailing list issues@eagle.apache.org Received: (qmail 53956 invoked by uid 99); 17 Apr 2017 08:08:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Apr 2017 08:08:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 98E5E1809FF for ; Mon, 17 Apr 2017 08:08:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id X9cjcwlGH82y for ; Mon, 17 Apr 2017 08:08:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AE62C5F20C for ; Mon, 17 Apr 2017 08:08:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2D604E0458 for ; Mon, 17 Apr 2017 08:08:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9F44221B47 for ; Mon, 17 Apr 2017 08:08:41 +0000 (UTC) Date: Mon, 17 Apr 2017 08:08:41 +0000 (UTC) From: "Jayesh (JIRA)" To: issues@eagle.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (EAGLE-984) Potential null dereference in SimpleWindowCounter#poll() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Apr 2017 08:08:45 -0000 [ https://issues.apache.org/jira/browse/EAGLE-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970828#comment-15970828 ] Jayesh commented on EAGLE-984: ------------------------------ [~ted_yu] would you be interested in providing fix for this ? > Potential null dereference in SimpleWindowCounter#poll() > -------------------------------------------------------- > > Key: EAGLE-984 > URL: https://issues.apache.org/jira/browse/EAGLE-984 > Project: Eagle > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > Fix For: v0.5.0 > > > Here is related code: > {code} > public Tuple2 poll() { > long oldestTimestamp = timeQueue.poll(); > Tuple2 pair = new Tuple2<>(oldestTimestamp, counter.get(oldestTimestamp)); > {code} > We should check the return value from timeQueue.poll() before casting to long. -- This message was sent by Atlassian JIRA (v6.3.15#6346)