Mailing-List: contact issues-help@eagle.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@eagle.apache.org
From: garrettlish <git@git.apache.org>
To: issues@eagle.apache.org
Reply-To: issues@eagle.apache.org
References: <git-pr-926-eagle@git.apache.org>
In-Reply-To: <git-pr-926-eagle@git.apache.org>
Subject: [GitHub] eagle pull request #926: EAGLE-993: add duplicate removal settings in policy...
Content-Type: text/plain
Message-Id: <20170421070520.A4F87E3A9C@git1-us-west.apache.org>
Date: Fri, 21 Apr 2017 07:05:20 +0000 (UTC)
archived-at: Fri, 21 Apr 2017 07:05:22 -0000

Github user garrettlish commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/926#discussion_r112622249
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertPublisherImpl.java ---
    @@ -73,11 +76,11 @@ public void nextEvent(PublishPartition partition, AlertStreamEvent event) {
         private void notifyAlert(PublishPartition partition, AlertStreamEvent event) {
             // remove the column values for publish plugin match
             partition.getColumnValues().clear();
    -        if (!publishPluginMapping.containsKey(partition)) {
    +        if (!publishPluginMapping.containsKey(partition.getPublishId())) {
    --- End diff --
    
    In publisher, we are able to specify the accepted streamId list, here how can we handle dropping the alert which comes from the stream which is NOT defined accepted streamId list? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---