eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EAGLE-1009) `return` inside `finally` block will result in losing exception
Date Tue, 18 Apr 2017 11:21:41 GMT

    [ https://issues.apache.org/jira/browse/EAGLE-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972510#comment-15972510
] 

ASF GitHub Bot commented on EAGLE-1009:
---------------------------------------

Github user qingwen220 commented on the issue:

    https://github.com/apache/eagle/pull/920
  
    I don't think there are exceptions lost in the code you modified.  All these try statements
are followed by catch statement which doesn't throw a new exception anymore. 
    
    I agree with your idea that DON'T return in finally block
    
    



> `return` inside `finally` block will result in losing exception
> ---------------------------------------------------------------
>
>                 Key: EAGLE-1009
>                 URL: https://issues.apache.org/jira/browse/EAGLE-1009
>             Project: Eagle
>          Issue Type: Bug
>          Components: Project Infrastructure
>    Affects Versions: v0.4.0
>            Reporter: Benedict Jin
>              Labels: JDK
>             Fix For: v0.5.0
>
>         Attachments: FinallyTest.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> `return` inside `finally` block will result in losing exception:
> * If the finally block completes abruptly for reason S, then the try statement completes
abruptly for reason S (and the throw of value V is discarded and forgotten).
> * If the finally block completes abruptly for reason S, then the try statement completes
abruptly for reason S (and reason R is discarded).
> reference:
> http://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message