eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EAGLE-993) add duplicate removal settings in policy definition
Date Fri, 28 Apr 2017 11:03:04 GMT

    [ https://issues.apache.org/jira/browse/EAGLE-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988640#comment-15988640
] 

ASF GitHub Bot commented on EAGLE-993:
--------------------------------------

Github user garrettlish commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/926#discussion_r113903238
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertPublisherImpl.java
---
    @@ -73,11 +76,11 @@ public void nextEvent(PublishPartition partition, AlertStreamEvent
event) {
         private void notifyAlert(PublishPartition partition, AlertStreamEvent event) {
             // remove the column values for publish plugin match
             partition.getColumnValues().clear();
    -        if (!publishPluginMapping.containsKey(partition)) {
    +        if (!publishPluginMapping.containsKey(partition.getPublishId())) {
    --- End diff --
    
    u can keep you simplified code, it looks good


> add duplicate removal settings in policy definition
> ---------------------------------------------------
>
>                 Key: EAGLE-993
>                 URL: https://issues.apache.org/jira/browse/EAGLE-993
>             Project: Eagle
>          Issue Type: Improvement
>    Affects Versions: v0.5.0
>            Reporter: Zhao, Qingwen
>            Assignee: Zhao, Qingwen
>
> customize duplicate fields & interval in each policy



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message