eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qingwen220 <...@git.apache.org>
Subject [GitHub] eagle pull request #926: EAGLE-993: add duplicate removal settings in policy...
Date Thu, 27 Apr 2017 14:05:41 GMT
Github user qingwen220 commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/926#discussion_r113703970
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertPublisherImpl.java
---
    @@ -73,11 +76,11 @@ public void nextEvent(PublishPartition partition, AlertStreamEvent
event) {
         private void notifyAlert(PublishPartition partition, AlertStreamEvent event) {
             // remove the column values for publish plugin match
             partition.getColumnValues().clear();
    -        if (!publishPluginMapping.containsKey(partition)) {
    +        if (!publishPluginMapping.containsKey(partition.getPublishId())) {
    --- End diff --
    
    Sorry for the late reply. 
    
    For the alert dropping off of unwanted stream is handled in AlertBoltOutputCollectorWrapper,
which are kept as it is. 
    
    In this class, i just simplify the coding, which should keeps the original logic. How
do you think? @garrettlish 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message