eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qingwen220 <...@git.apache.org>
Subject [GitHub] eagle pull request #926: EAGLE-993: add duplicate removal settings in policy...
Date Fri, 21 Apr 2017 01:55:27 GMT
Github user qingwen220 commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/926#discussion_r112595515
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
---
    @@ -215,7 +214,6 @@ public PublishmentType getPluginType() {
                     .name("Email")
                     .type(AlertEmailPublisher.class)
                     .description("Email alert publisher")
    -                .field("subject")
    --- End diff --
    
    Yes. 
    
    As we already define the email subject in the policy definition. it's a little duplicated.
How do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message