eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qingwen220 <...@git.apache.org>
Subject [GitHub] eagle issue #920: [EAGLE-1009] Fix losing exception issues
Date Tue, 18 Apr 2017 11:20:53 GMT
Github user qingwen220 commented on the issue:

    https://github.com/apache/eagle/pull/920
  
    I don't think there are exceptions lost in the code you modified.  All these try statements
are followed by catch statement which doesn't throw a new exception anymore. 
    
    I agree with your idea that DON'T return in finally block
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message