eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EAGLE-924) urls to healthy and unhealthy region-servers in hbase dashboard is not accurate enough
Date Mon, 27 Feb 2017 10:32:45 GMT

    [ https://issues.apache.org/jira/browse/EAGLE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885527#comment-15885527
] 

ASF GitHub Bot commented on EAGLE-924:
--------------------------------------

Github user haoch commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/840#discussion_r103176287
  
    --- Diff: eagle-metric/eagle-hbase-web/src/main/webapp/app/apps/hbase/ctrls/overview.js
---
    @@ -59,7 +59,10 @@
     
     				$scope.site = $wrapState.param.siteId;
     				var result = cache[name] || activeMasterInfo._promise.then(function (res) {
    -						var hostname = cache[hostname] = cache[hostname] || res[0].tags.hostname;
    +						if(typeof res[0].tags === 'undefined') {
    --- End diff --
    
    Maybe it possible:  `res.length == 0`?


> urls to healthy and unhealthy region-servers in hbase dashboard is not accurate enough
> --------------------------------------------------------------------------------------
>
>                 Key: EAGLE-924
>                 URL: https://issues.apache.org/jira/browse/EAGLE-924
>             Project: Eagle
>          Issue Type: Bug
>          Components: App::Hadoop JMX Monitor
>    Affects Versions: v0.5.0
>            Reporter: Michael Wu
>            Assignee: Hao Chen
>             Fix For: v0.6.0
>
>         Attachments: Screen Shot 2017-02-22 at 16.24.09.png
>
>
> Issue: In hbase dashboard of a site, in the top section, there are 2 links referring
to urls of healthy and unhealthy region-server lists. But currently, when people click the
link, the page is directed to a full list of all region-servers, not the corresponding healthy-list
or unhealthy-list.
> Suggestion: we can add some filter in the url, for example, append "?status=healthy"
or "?status=unhealthy" to the url, and update the link with new urls.
> Please see the screenshot in the attachment of this ticket.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message