Mailing-List: contact issues-help@eagle.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@eagle.apache.org
From: zombieJ <git@git.apache.org>
To: issues@eagle.apache.org
Reply-To: issues@eagle.apache.org
References: <git-pr-753-eagle@git.apache.org>
In-Reply-To: <git-pr-753-eagle@git.apache.org>
Subject: [GitHub] eagle pull request #753: EAGLE-845 JMX Dashboard
Content-Type: text/plain
Message-Id: <20170104075217.886D4DFADF@git1-us-west.apache.org>
Date: Wed,  4 Jan 2017 07:52:17 +0000 (UTC)
archived-at: Wed, 04 Jan 2017 07:52:19 -0000

Github user zombieJ commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/753#discussion_r94539902
  
    --- Diff: eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/ctrls/overview.js ---
    @@ -21,52 +21,193 @@
     	 * `register` without params will load the module which using require
     	 */
     	register(function (hadoopMetricApp) {
    -		hadoopMetricApp.controller("overviewCtrl", function ($scope, PageConfig) {
    +		hadoopMetricApp.controller("overviewCtrl", function ($q, $wrapState, $scope, PageConfig, METRIC, Time) {
    +			var cache = {};
    +			var mapRes = common.map2;
    +			$scope.site = $wrapState.param.siteId;
    +			var activeMasterInfo = METRIC.hbaseActiveMaster($scope.site);
    +			var metricMap = common.map1;
    --- End diff --
    
    * You can't modifiy `common` library for application usage.
    * `map1` is magic name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---