Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 74845200C11 for ; Fri, 30 Dec 2016 09:06:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7346D160B3F; Fri, 30 Dec 2016 08:06:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7023B160B48 for ; Fri, 30 Dec 2016 09:06:00 +0100 (CET) Received: (qmail 17746 invoked by uid 500); 30 Dec 2016 08:05:59 -0000 Mailing-List: contact issues-help@eagle.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@eagle.apache.org Delivered-To: mailing list issues@eagle.apache.org Received: (qmail 17620 invoked by uid 99); 30 Dec 2016 08:05:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Dec 2016 08:05:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5EB292C2A68 for ; Fri, 30 Dec 2016 08:05:59 +0000 (UTC) Date: Fri, 30 Dec 2016 08:05:59 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@eagle.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (EAGLE-845) JMX Dashboard MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 30 Dec 2016 08:06:01 -0000 [ https://issues.apache.org/jira/browse/EAGLE-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787163#comment-15787163 ] ASF GitHub Bot commented on EAGLE-845: -------------------------------------- Github user zombieJ commented on a diff in the pull request: https://github.com/apache/eagle/pull/753#discussion_r94208166 --- Diff: eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/ctrls/regionDetailCtrl.js --- @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +(function () { + /** + * `register` without params will load the module which using require + */ + register(function (hadoopMetricApp) { + hadoopMetricApp.controller("regionDetailCtrl", function ($q, $wrapState, $scope, PageConfig, Time, METRIC) { + var cache = {}; + $scope.site = $wrapState.param.siteId; + $scope.hostname = $wrapState.param.hostname; + PageConfig.title = 'RegionServer ' + "(" + $scope.hostname + ")"; + $scope.metricList = []; + Time.autoRefresh = false; + + var METRIC_NAME = [ + "hadoop.memory.nonheapmemoryusage.used", + "hadoop.memory.heapmemoryusage.used", + "hadoop.bufferpool.direct.memoryused", + "hadoop.hbase.jvm.gccount", + "hadoop.hbase.jvm.gctimemillis", + "hadoop.hbase.ipc.ipc.queuesize", + "hadoop.hbase.ipc.ipc.numcallsingeneralqueue", + "hadoop.hbase.ipc.ipc.numactivehandler", + "hadoop.hbase.ipc.ipc.queuecalltime_99th_percentile", + "hadoop.hbase.ipc.ipc.processcalltime_99th_percentile", + "hadoop.hbase.ipc.ipc.queuecalltime_num_ops", + "hadoop.hbase.ipc.ipc.processcalltime_num_ops", + "hadoop.hbase.regionserver.server.regioncount", + "hadoop.hbase.regionserver.server.storecount", + "hadoop.hbase.regionserver.server.memstoresize", + "hadoop.hbase.regionserver.server.storefilesize", + "hadoop.hbase.regionserver.server.totalrequestcount", + "hadoop.hbase.regionserver.server.readrequestcount", + "hadoop.hbase.regionserver.server.writerequestcount", + "hadoop.hbase.regionserver.server.splitqueuelength", + "hadoop.hbase.regionserver.server.compactionqueuelength", + "hadoop.hbase.regionserver.server.flushqueuelength", + "hadoop.hbase.regionserver.server.blockcachesize", + "hadoop.hbase.regionserver.server.blockcachehitcount", + "hadoop.hbase.regionserver.server.blockcounthitpercent" + ]; + + + $scope.refresh = function () { + var startTime = Time.startTime(); + var endTime = Time.endTime(); + + var promies = []; + $.each(METRIC_NAME, function (i, metric_name) { + promies.push(generateHbaseMetric(metric_name, startTime, endTime)); + }); + promies.push(METRIC.regionserverStatus($scope.hostname, $scope.site)); + + $q.all(promies).then(function (res) { + + var sizeoption = { + animation: false, + tooltip: { + formatter: function (points) { + return points[0].name + "
" + + $.map(points, function (point) { + return ' ' + + point.seriesName + ": " + + common.number.abbr(point.value, true); + }).reverse().join("
"); + } + }, + legend: { + x: 'center', y: 'bottom' + }, + areaStyle: {normal: {}}, + yAxis: [{ + axisLabel: { + formatter: function (value) { + return common.number.sizeFormat(value, 0); + } + } + }] + }; + + var gctimeoption = { + legend: { + x: 'center', y: 'bottom' + }, + yAxis: [{ + axisLabel: { + formatter: function (value) { + return value / 1000 + ' S'; + } + } + }] + }; + $scope.metricList = []; + $scope.metricList.push(mergeSeries("Memory Usage", [res[0], res[1]], ["nonheap", "heap"], sizeoption)); --- End diff -- Same. No magic number > JMX Dashboard > ------------- > > Key: EAGLE-845 > URL: https://issues.apache.org/jira/browse/EAGLE-845 > Project: Eagle > Issue Type: New Feature > Components: Hadoop JMX Monitor, Web UI > Reporter: JiJun Tang > Assignee: Lingang Deng > -- This message was sent by Atlassian JIRA (v6.3.4#6332)