Mailing-List: contact issues-help@eagle.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@eagle.incubator.apache.org
Date: Mon, 19 Dec 2016 02:12:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@eagle.incubator.apache.org
Message-ID: <JIRA.13029027.1482107570000.549334.1482113578325@Atlassian.JIRA>
In-Reply-To: <JIRA.13029027.1482107570000@Atlassian.JIRA>
References: <JIRA.13029027.1482107570000@Atlassian.JIRA> <JIRA.13029027.1482107570831@arcas>
Subject: [jira] [Commented] (EAGLE-844) Potential NPE issue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 19 Dec 2016 02:13:04 -0000


    [ https://issues.apache.org/jira/browse/EAGLE-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759898#comment-15759898 ] 

ASF GitHub Bot commented on EAGLE-844:
--------------------------------------

Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/751#discussion_r92959638
  
    --- Diff: eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java ---
    @@ -65,7 +65,7 @@ public void init() {
             try {
                 admin = new HBaseAdmin(conf);
                 Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
    -            if (entityServiceMap != null || entityServiceMap.values() != null) {
    +            if (entityServiceMap != null && entityServiceMap.values() != null) {
    --- End diff --
    
    do we still need to check "entityServiceMap.values() != null"?  it should not return null


> Potential NPE issue
> -------------------
>
>                 Key: EAGLE-844
>                 URL: https://issues.apache.org/jira/browse/EAGLE-844
>             Project: Eagle
>          Issue Type: Bug
>            Reporter: Jaechang Nam
>            Priority: Minor
>
> The following file accessed on Dec 18 2016 (Github revision id: 8fe968cb7e340e2f21711b5a0f701e760cb91d59), eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java, seems to have a potential null pointer exception.
> Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
>             if (entityServiceMap != null || entityServiceMap.values() != null) {
>                 for (EntityDefinition entityDefinition : entityServiceMap.values()) {
>                     createTable(entityDefinition);
>                 }
>             }
> ---
> if entityServiceMap is null, entityServiceMap.values() could have NPE.
> I have no idea if entityServiceMap can be null. Having said that, at least it could be a code smell.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)