Mailing-List: contact issues-help@eagle.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@eagle.incubator.apache.org
Date: Mon, 19 Dec 2016 01:42:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@eagle.incubator.apache.org
Message-ID: <JIRA.13029027.1482107570000.549253.1482111778544@Atlassian.JIRA>
In-Reply-To: <JIRA.13029027.1482107570000@Atlassian.JIRA>
References: <JIRA.13029027.1482107570000@Atlassian.JIRA> <JIRA.13029027.1482107570831@arcas>
Subject: [jira] [Commented] (EAGLE-844) Potential NPE issue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 19 Dec 2016 01:43:03 -0000


    [ https://issues.apache.org/jira/browse/EAGLE-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759855#comment-15759855 ] 

ASF GitHub Bot commented on EAGLE-844:
--------------------------------------

GitHub user lifove opened a pull request:

    https://github.com/apache/incubator-eagle/pull/751

    [EAGLE-844] Fix a potential NPE

    <!--
    {% comment %}
    Licensed to the Apache Software Foundation (ASF) under one or more
    contributor license agreements.  See the NOTICE file distributed with
    this work for additional information regarding copyright ownership.
    The ASF licenses this file to you under the Apache License, Version 2.0
    (the "License"); you may not use this file except in compliance with
    the License.  You may obtain a copy of the License at
    
    http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
    {% endcomment %}
    -->
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[EAGLE-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lifove/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #751
    
----
commit dc73f0e92d9c617d562105c0353ecb3714c87f27
Author: JC <jc@lifove.net>
Date:   2016-12-19T01:36:10Z

    [EAGLE-844] Fix potential NPE

----


> Potential NPE issue
> -------------------
>
>                 Key: EAGLE-844
>                 URL: https://issues.apache.org/jira/browse/EAGLE-844
>             Project: Eagle
>          Issue Type: Bug
>            Reporter: Jaechang Nam
>            Priority: Minor
>
> The following file accessed on Dec 18 2016 (Github revision id: 8fe968cb7e340e2f21711b5a0f701e760cb91d59), eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java, seems to have a potential null pointer exception.
> Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
>             if (entityServiceMap != null || entityServiceMap.values() != null) {
>                 for (EntityDefinition entityDefinition : entityServiceMap.values()) {
>                     createTable(entityDefinition);
>                 }
>             }
> ---
> if entityServiceMap is null, entityServiceMap.values() could have NPE.
> I have no idea if entityServiceMap can be null. Having said that, at least it could be a code smell.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)