Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC84D200BD8 for ; Wed, 7 Dec 2016 11:52:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CB4EA160B0A; Wed, 7 Dec 2016 10:52:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 201C0160AFD for ; Wed, 7 Dec 2016 11:52:03 +0100 (CET) Received: (qmail 96154 invoked by uid 500); 7 Dec 2016 10:52:03 -0000 Mailing-List: contact issues-help@eagle.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@eagle.incubator.apache.org Delivered-To: mailing list issues@eagle.incubator.apache.org Received: (qmail 96145 invoked by uid 99); 7 Dec 2016 10:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 10:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C922EC0333 for ; Wed, 7 Dec 2016 10:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Fydou-24V717 for ; Wed, 7 Dec 2016 10:52:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id ECAD25FC41 for ; Wed, 7 Dec 2016 10:51:59 +0000 (UTC) Received: (qmail 95316 invoked by uid 99); 7 Dec 2016 10:51:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 10:51:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 00EFD2C0086 for ; Wed, 7 Dec 2016 10:51:59 +0000 (UTC) Date: Wed, 7 Dec 2016 10:51:59 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@eagle.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (EAGLE-828) CuratorFramework should be closed after it was created by applications MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 07 Dec 2016 10:52:05 -0000 [ https://issues.apache.org/jira/browse/EAGLE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728441#comment-15728441 ] ASF GitHub Bot commented on EAGLE-828: -------------------------------------- GitHub user chitin opened a pull request: https://github.com/apache/incubator-eagle/pull/720 EAGLE-828 CuratorFramework should be closed after it was created by applications EAGLE-828 CuratorFramework should be closed after it was created by applications - Add close method in dependent apps. - Add ut for the close method, make sure curatorFramework has be closed. https://issues.apache.org/jira/browse/EAGLE-828 You can merge this pull request into a Git repository by running: $ git pull https://github.com/chitin/incubator-eagle EAGLE-828 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/720.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #720 ---- commit 25a0a8fc20c0eea3782becfb38e259eb21b3b004 Author: chitin Date: 2016-12-07T10:48:59Z EAGLE-828 CuratorFramework should be closed after it was created by applications - Add close method in dependent apps. - Add ut for the close method, make sure curatorFramework has be closed. https://issues.apache.org/jira/browse/EAGLE-828 ---- > CuratorFramework should be closed after it was created by applications > ---------------------------------------------------------------------- > > Key: EAGLE-828 > URL: https://issues.apache.org/jira/browse/EAGLE-828 > Project: Eagle > Issue Type: Bug > Reporter: Lingang Deng > Assignee: Lingang Deng > Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)