Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A74DF200BFB for ; Wed, 28 Dec 2016 03:15:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A5EC7160B3D; Wed, 28 Dec 2016 02:15:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EC96F160B31 for ; Wed, 28 Dec 2016 03:15:01 +0100 (CET) Received: (qmail 82185 invoked by uid 500); 28 Dec 2016 02:15:01 -0000 Mailing-List: contact issues-help@eagle.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@eagle.apache.org Delivered-To: mailing list issues@eagle.apache.org Received: (qmail 82176 invoked by uid 99); 28 Dec 2016 02:15:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Dec 2016 02:15:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C6AA3C03F3 for ; Wed, 28 Dec 2016 02:15:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Hbm4Ewz3iTPp for ; Wed, 28 Dec 2016 02:15:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 5E2795F39C for ; Wed, 28 Dec 2016 02:14:59 +0000 (UTC) Received: (qmail 80058 invoked by uid 99); 28 Dec 2016 02:14:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Dec 2016 02:14:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7AFAA2C0059 for ; Wed, 28 Dec 2016 02:14:58 +0000 (UTC) Date: Wed, 28 Dec 2016 02:14:58 +0000 (UTC) From: "Jayesh (JIRA)" To: issues@eagle.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (EAGLE-687) When creating sites in UI and metadata storaged as jdbc, the field "Description" can't be null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 28 Dec 2016 02:15:02 -0000 [ https://issues.apache.org/jira/browse/EAGLE-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15781811#comment-15781811 ] Jayesh commented on EAGLE-687: ------------------------------ [~chitin], after reviewing the code responsible for this, i see much bigger issue at how SiteEntityToRelation class is designed. so right now the issue is about not able to set null description, but later it might cause similar issues for other fields ( specially when new queries are introduced ) proposed solution: SiteEntityToRelation.accept method should take variable argument instead of siteEntity, that way it can be controlled well at a time of creating query using queryService. > When creating sites in UI and metadata storaged as jdbc, the field "Description" can't be null > ----------------------------------------------------------------------------------------------- > > Key: EAGLE-687 > URL: https://issues.apache.org/jira/browse/EAGLE-687 > Project: Eagle > Issue Type: Bug > Reporter: Lingang Deng > Priority: Minor > Fix For: v0.5.0 > > > When creating sites in UI and metadata storaged as jdbc, the field "Description" can't be null, or we will get error > {code} > ERROR [2016-10-26 15:54:24,554] org.apache.eagle.metadata.store.jdbc.JDBCMetadataMetadataStoreServiceImpl: Error to insert batch: INSERT INTO sites (siteid, sitename, description, createdtime, modifiedtime, uuid) VALUES (?, ?, ?, ?, ?, ?) > ! java.sql.SQLException: No value specified for parameter 6 > {code} > The filed "Description" is checked in the background. So whether this field can be empty or validated in the front end , it's elective. -- This message was sent by Atlassian JIRA (v6.3.4#6332)