Mailing-List: contact issues-help@eagle.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@eagle.incubator.apache.org
From: garrettlish <git@git.apache.org>
To: issues@eagle.incubator.apache.org
Reply-To: issues@eagle.incubator.apache.org
References: <git-pr-732-incubator-eagle@git.apache.org>
In-Reply-To: <git-pr-732-incubator-eagle@git.apache.org>
Subject: [GitHub] incubator-eagle pull request #732: [EAGLE-837] Stream definition change does...
Content-Type: text/plain
Message-Id: <20161216021603.D650AE3908@git1-us-west.apache.org>
Date: Fri, 16 Dec 2016 02:16:03 +0000 (UTC)
archived-at: Fri, 16 Dec 2016 02:16:09 -0000

Github user garrettlish commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/732#discussion_r92740230
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/java/org/apache/eagle/alert/engine/router/TestAlertBolt.java ---
    @@ -443,6 +447,83 @@ public void reportError(Throwable error) {
     
             Assert.assertTrue(recieved.get());
         }
    +    
    +    @Test
    +    public void testStreamDefinitionChange() throws IOException {
    +        PolicyDefinition def = new PolicyDefinition();
    +        def.setName("policy-definition");
    +        def.setInputStreams(Arrays.asList(TEST_STREAM));
    +
    +        PolicyDefinition.Definition definition = new PolicyDefinition.Definition();
    +        definition.setType(PolicyStreamHandlers.CUSTOMIZED_ENGINE);
    +        definition.setHandlerClass("org.apache.eagle.alert.engine.router.CustomizedHandler");
    +        definition.setValue("PT0M,plain,1,host,host1");
    +        def.setDefinition(definition);
    +        def.setPartitionSpec(Arrays.asList(createPartition()));
    +
    +        AlertBoltSpec boltSpecs = new AlertBoltSpec();
    +
    +        AtomicBoolean recieved = new AtomicBoolean(false);
    +        OutputCollector collector = new OutputCollector(new IOutputCollector() {
    +            @Override
    +            public List<Integer> emit(String streamId, Collection<Tuple> anchors, List<Object> tuple) {
    +                recieved.set(true);
    +                return Collections.emptyList();
    +            }
    +
    +            @Override
    +            public void emitDirect(int taskId, String streamId, Collection<Tuple> anchors, List<Object> tuple) {
    +            }
    +
    +            @Override
    +            public void ack(Tuple input) {
    +            }
    +
    +            @Override
    +            public void fail(Tuple input) {
    +            }
    +
    +            @Override
    +            public void reportError(Throwable error) {
    +            }
    +        });
    +        AlertBolt bolt = createAlertBolt(collector);
    +
    +        boltSpecs.getBoltPoliciesMap().put(bolt.getBoltId(), Arrays.asList(def));
    +        boltSpecs.setVersion("spec_" + System.currentTimeMillis());
    +        // stream def map
    +        Map<String, StreamDefinition> sds = new HashMap();
    +        StreamDefinition sdTest = new StreamDefinition();
    +        sdTest.setStreamId(TEST_STREAM);
    +        sds.put(sdTest.getStreamId(), sdTest);
    +        
    +        boltSpecs.addPublishPartition(TEST_STREAM, "policy-definition", "testAlertPublish", null);
    +
    +        bolt.onAlertBoltSpecChange(boltSpecs, sds);
    +
    +        // how to assert
    +        Tuple t = createTuple(bolt, boltSpecs.getVersion());
    +
    +        bolt.execute(t);
    +
    +        Assert.assertTrue(recieved.get());
    +        
    +        LOG.info("Update stream");
    +        sds = new HashMap();
    +        sdTest = new StreamDefinition();
    +        sdTest.setStreamId(TEST_STREAM);
    +        sds.put(sdTest.getStreamId(), sdTest);
    +        sdTest.setDescription("update the stream");
    +        bolt.onAlertBoltSpecChange(boltSpecs, sds);
    +        
    +        LOG.info("No any change");
    +        sds = new HashMap();
    +        sdTest = new StreamDefinition();
    +        sdTest.setStreamId(TEST_STREAM);
    +        sds.put(sdTest.getStreamId(), sdTest);
    +        sdTest.setDescription("update the stream");
    +        bolt.onAlertBoltSpecChange(boltSpecs, sds);
    --- End diff --
    
    asserts updated in https://github.com/apache/incubator-eagle/pull/738


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---