eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jhsenjaliya <...@git.apache.org>
Subject [GitHub] eagle pull request #758: [EAGLE-687] updating SiteEntityToRelation to accept...
Date Wed, 28 Dec 2016 08:26:35 GMT
GitHub user jhsenjaliya opened a pull request:

    https://github.com/apache/eagle/pull/758

    [EAGLE-687] updating SiteEntityToRelation to accept null values

    Currently if you create site with any of the field set to NULL, it will throw 
    explored the way to use preparedStatements with explicitly specified parameters but that
would require quite a large refactoring on entire metadata module.
    so came up with the fix that is based on current assumptions in SiteEntityServiceJDBCImpl
which is forming the sql in particular way that suits in SiteEntityToRelation.accept method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jhsenjaliya/eagle EAGLE-687

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/eagle/pull/758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #758
    
----
commit 3ffc3a9032aa207667b7a0ad9ccdb76bfcc0dfe1
Author: Jay <jhsonline@gmail.com>
Date:   2016-12-28T07:54:05Z

    updating SiteEntityToRelation to accept null values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message